I am looking to pull request soon in order to update and add additional resource actions for the base Xero node. Previously I simply developed a copy of the base node as whole separate one for development purposes. But also, I honestly never heavily utilized Git or Github properly either.
Also, I did an entirely separate one originally for other agencies to test out internally with clients they service, and we didn’t want to break any existing workflows using the base node at the time.
I originally was thinking of releasing the node as a community only node, but now I would like to have it part of the base n8n given the amount of work I put into it.
I’ve added a number of new actions, and updating current ones for Contacts and Invoices to add additional parameters, features, and fixes as well.
But the amount of work done so far is a bit larger than a single feature addition/update, and based on the guidelines for contributing it mentions to only focus on Small PRs only.
Because the number of features added are higher than usual (about 20+ new actions across several new resources at the moment), this requires increase in scopes accordingly. To which then may slow down progress since I know the team obviously will only approve new scope requirements in OAuth as needed for the pr/feature.
Should I simply create and submit the PR as one overhaul push, or no, stick to guidelines and only PR per 1 new resource improvement/update only?
Want to get an idea the best way to go about it as I don’t want to do a pull to re-add properly my changes and then go too far too quickly that will simply get rejected.
Describe the problem/error/question
Should I simply create and submit the PR as one overhaul push, or no, stick to guidelines and only PR per 1 new resource improvement/update only?
Any guidance is always appreciated!
Information on your n8n setup
- **n8n version:1.100.1
- Database (default: SQLite):
- n8n EXECUTIONS_PROCESS setting (default: own, main):
- Running n8n via (Docker):
- Operating system: N/A
