FTP node consumes a lot of memory and connections

Tung_Nguyen · October 27, 2023, 7:33am

It would help if there was a node for:

My use case:

When I use FTP Node it consume many memory!

               if (protocol === 'sftp') {
				await sftp!.end();
			} else {
				await ftp!.end();
			}
		} catch (error) {
			if (this.continueOnFail()) {
				return [[{ json: { error: error.message } }]];
			}

			throw error;

end() method should be call at on the finally block code.

Any resources to support this?

github.com

n8n-io/n8n/blob/master/packages/nodes-base/nodes/Ftp/Ftp.node.ts

import type {
	ICredentialDataDecryptedObject,
	ICredentialsDecrypted,
	ICredentialTestFunctions,
	IDataObject,
	IExecuteFunctions,
	INodeCredentialTestResult,
	INodeExecutionData,
	INodeType,
	INodeTypeDescription,
	JsonObject,
} from 'n8n-workflow';
import { BINARY_ENCODING, NodeApiError } from 'n8n-workflow';
import { formatPrivateKey } from '@utils/utilities';
import { createWriteStream } from 'fs';
import { basename, dirname } from 'path';
import type { Readable } from 'stream';
import { pipeline } from 'stream';
import { promisify } from 'util';
import { file as tmpFile } from 'tmp-promise';

This file has been truncated. show original

Are you willing to work on this?

It

Jon · October 27, 2023, 7:38am

Good spot, I will look into this shortly.