Time out node [GOT CREATED]

Cemcat · February 14, 2020, 12:34pm

Hi everyone,

During the creation of a workflow I needed a custom node to create a time out when a webhook is called. I know it could be made with the Function node but finally I decided to have this node because I will use it often.

I would like to share it with all of you but I don’t find the way to publish it, so if you can guide me to do so I would appreciate it.

Thank you a lot,
Cemcat

jan · February 14, 2020, 3:23pm

Hello @Cemcat! First welcome to the community and very amazing to hear that you want to contribute to it. Sadly did you choose probably the wrong node for that (more about that below)

But to answer your question first. You can add the node like described here to the n8n repository:

github.com

n8n-io/n8n/blob/master/CONTRIBUTING.md#create-a-new-node-to-contribute-to-n8n

# Contributing to n8n

Great that you are here and you want to contribute to n8n

## Contents

- [Code of Conduct](#code-of-conduct)
- [Directory Structure](#directory-structure)
- [Development Setup](#development-setup)
- [Development Cycle](#development-cycle)
- [Create Custom Nodes](#create-custom-nodes)
- [Create a new node to contribute to n8n](#create-a-new-node-to-contribute-to-n8n)
- [Checklist before submitting a new node](#checklist-before-submitting-a-new-node)
- [Extend Documentation](#extend-documentation)
- [Contributor License Agreement](#contributor-license-agreement)

## Code of conduct

This project and everyone participating in it are governed by the Code of
Conduct which can be found in the file [CODE_OF_CONDUCT.md](CODE_OF_CONDUCT.md).

This file has been truncated. show original

and then create a pull request as described here:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

Now back to why it is probably the wrong node to contriute. The reason is that I would probably not merge/add it.
There is a discussion about such a node here and what makes it so complicated to create to work at scale:

The issue is that if we add the simple version of such a node, people will not be aware of the implications. Meaning if a node exists and they have the need to wait a week between two nodes they would use it for that and that is very dangerous. The reason is that workflows would keep on running and so be active for the whole time and eat resources until the server crashes. And even worst, all the data of all that active workflows would be lost as it never has been saved (as it does only get saved after the workflow finishes execution).
So when I add such a node I want to be sure that it is “secure” to use for all people by temporarily stopping the workflow, saving the data and then spinning it up again. Hope that makes sense.

Cemcat · February 17, 2020, 7:40am

Good morning @jan ,

It has sense what you explained, but I will use it as personal node . Anyway I think would be really useful to have the option in webhook and start node to set some timeout before start the flow. As example, when is updated the user information are executed some triggers in the SQL server, so I need to be sure that the information is correctly saved.

Thank you for the explanation about how to collaborate.

Cemcat