Warning "credential are not set" while it is actualy set

Valerian_Lebert · July 2, 2024, 11:58am

Hi

I updated recently to version 1.47.1

When I open an existing workflow, I have warning “credentials are not set” on HTTP Request nodes.

The credential is however set :

If I run the workflow it runs without auth errors
If I open the node and just re-select the credential + OK il removes the warning

I think do I need to re-save all workflow ?

Is this an identified bug ?

Valerian_Lebert · July 2, 2024, 12:15pm

New information : even if I do save the workflow after re-setting the credential, the warning may appear again later

Jon · July 2, 2024, 3:43pm

Hey @Valerian_Lebert,

Can you try updating to 1.48.0 this was fixed as part of the PR below.

github.com/n8n-io/n8n

fix(editor): Load credentials for workflow before determining credentials errors

n8n-io:master ← n8n-io:ado-2280-http-request-shows-credentials-not-set-warning-in-ui-despite

opened 07:16PM - 26 Jun 24 UTC

RicardoE105

+8 -5

## Summary We are attempting to get node credentials errors before we load th…e credentials in the store. This causes the UI to show "issues with the credentials" even though there are none. Loading the credentials as soon as we initiate the view seems to fix the issue. Specifically, we are trying to get the credentials errors for `predefinedCredentialType` and [here](https://github.com/n8n-io/n8n/blob/e995309789c886f9203290e6973149ad96102fb2/packages/editor-ui/src/composables/useNodeHelpers.ts#L397), we attempt to get the type by calling `getCredentialsByType`, but that method depends on `allCredentialsByType` which at the same time depends on the state property `allCredentials`. At the time of calling the credentials have not been loaded in the store, so it returns `[]` even though it should have returned the credentials type. This empty array causes the logic to show an incorrect error. The execution does follow: `Mounted` -> `ready (jsplumb)` -> `initView` - > `openWorkflow` -> `addNodes` -> `refreshNodeIssues` -> `getNodeIssue` ->` getNodeCredentialIssues` -> `credentialsStore.getCredentialsByType` (were we return [] because the store has not loaded yet.) -> at some point later we load the credentials for that workflow in the store (this should have happened before getNodeCredentialIssues) @cstuncsik Can you please have a look? I'm not too familiar with this side of the code, so I'm not sure whether this would break something else or if it's the best approach to solve the issue. So far, it seems to fix the problem. ## Related Linear tickets, Github issues, and Community forum posts https://linear.app/n8n/issue/ADO-2280/http-request-shows-credentials-not-set-warning-in-ui-despite ## Before changes https://www.loom.com/share/5c07e76288e84041b6b8abdf99a33b30?from_recorder=1&focus_title=1 ## After the changes https://www.loom.com/share/7ac13702dced4784bc1bb820a29ed5bc?from_recorder=1&focus_title=1 ## Review / Merge checklist - [x] PR title and summary are descriptive. ([conventions](../blob/master/.github/pull_request_title_conventions.md))  - [ ] Tests included.  - [ ] PR Labeled with `release/backport` (if the PR is an urgent fix that needs to be backported)

Valerian_Lebert · July 2, 2024, 7:40pm

I did update, it seems fixed.

aiandwifi · July 2, 2024, 10:19pm

Thanks so much for fixing this. I burned a day trying to figure out what I broke.