Bug: File Content field hidden under Binary Data (Nextcloud Node)

Questions
1

Nextcloud

2019-11-11_18-32
2019-11-11_18-35

Dropbox

2019-11-11_18-33
2019-11-12_07-26

2

@jan Looking on the code I think if binary data is ON then file content should be hidden right? looks like you can do either one or the other at least on the nextcloud integration.

} else if (operation === 'upload') {
				// ----------------------------------
				//         upload
				// ----------------------------------

				requestMethod = 'PUT';
				endpoint = this.getNodeParameter('path', i) as string;

				if (this.getNodeParameter('binaryDataUpload', i) === true) {
					// Is binary file to upload
					const item = items[i];

					if (item.binary === undefined) {
						throw new Error('No binary data exists on item!');
					}

					const propertyNameUpload = this.getNodeParameter('binaryPropertyName', i) as string;


					if (item.binary[propertyNameUpload] === undefined) {
						throw new Error(`No binary data property "${propertyNameUpload}" does not exists on item!`);
					}

					body = Buffer.from(item.binary[propertyNameUpload].data, BINARY_ENCODING);
				} else {
					// Is text file
					body = this.getNodeParameter('fileContent', i) as string;
				}

If so, the fix would be changing this show condition for the fileContent property.

3

Not on my computer right now. But @RicardoE105 is right. It should display either one or the other.

So if “Binary Data” is active it should only be possible to set the name of the binary property to read from and if deactivated it should only be possible to set the file content directly.

4

@jan Send you a PR fixing this!

5

@RicardoE105 Thanks a lot! Is merged. Will release a new version with the fix later today.