n8n
January 6, 2024, 12:42pm
2
It looks like your topic is missing some important information. Could you provide the following if applicable.
n8n version: Database (default: SQLite): n8n EXECUTIONS_PROCESS setting (default: own, main): Running n8n via (Docker, npm, n8n cloud, desktop app): Operating system:
jan
January 6, 2024, 7:18pm
3
Can you please provide additional information about what is supposedly wrong. We will then do our best to help. Generally simply always best to fill the template instead of deleting it. Thanks!
I’ve had this to on mine as well. If its a one item run it tends to say 2 or 3 while its running on the manual execution. Once the manual execution is over the count goes back to one.
jan
January 6, 2024, 8:21pm
5
Ah yes, that is a know and already fixed issue that will BE released with the next version.
Here the PR:
n8n-io:master ← n8n-io:ado-1596-bug-items-count-display-in-running-workflow
opened 07:54PM - 22 Dec 23 UTC
## Summary
> Describe what the PR does and how to test. Photos and videos are r… ecommended.
Every time the `MainHeader` component is created, we register a new handler for the "push" messages. Unfortunately this becomes an issue if you go multiple times to a page that renders the `MainHeader`, e.g `/workflow/:id`, without refreshing the page; because all handlers will be called, causing behavior duplication.
I added the possibility of passing an ID, and made impossible to have multiple handlers with the same ID However, it does not seems to be needed to support an array of handlers in the pushConnection store. If that is the case:
1. We might want to have only one handler for the push connections at all times, which would be a much simpler approach.
2. Register the handler on app.mount instead.
The issue seems to have been introduced [here](https://github.com/n8n-io/n8n/pull/7763/files#diff-f5dae80a64b9951bb6691f1b9d439423cf84fa0cc9601b3f2c00904f3135e8deR48)
Before the change:
https://www.loom.com/share/85cf8ef896254d848a13a6c6438daa47
With the change:
https://www.loom.com/share/f5c4ffac421d46cc8e389364e1c357d3
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1596/bug-items-count-display-in-running-workflow
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it from happening again.
> A feature is not complete without tests.
1 Like
system
February 27, 2024, 4:29pm
6
This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.
jan
February 28, 2024, 7:37am
7
Looks like the community ticket was not linked in the PR. For that reason is the comment missing.
The fix got released with [email protected]
