Error visaul artefact on predefined credential type, after reloading the page

artildo · July 12, 2024, 11:14am

Describe the problem/error/question

I have a Notion Credential inserted into a HTTP-request node
On page reload it gives an error. It gets away when I re-choose the credential.

However, it’s not an error, the process works fine. Just a visual artefact

From inside:

The flow still works:

Information on your n8n setup

n8n version: 1.47.3
Database (default: SQLite): default
n8n EXECUTIONS_PROCESS setting (default: own, main): default
Running n8n via (Docker, npm, n8n cloud, desktop app): Docker-compose
Operating system: Ubuntu 22

Jon · July 12, 2024, 11:33am

Hey @artildo,

I believe this was fixed a couple of version ago, Can you update your n8n instance to 1.48.0 or 1.49.0 and see if the error is still there.

Edit: Yeah was fixed in 1.48.0 with the PR below.

github.com/n8n-io/n8n

fix(editor): Load credentials for workflow before determining credentials errors

n8n-io:master ← n8n-io:ado-2280-http-request-shows-credentials-not-set-warning-in-ui-despite

opened 07:16PM - 26 Jun 24 UTC

RicardoE105

+8 -5

## Summary We are attempting to get node credentials errors before we load th…e credentials in the store. This causes the UI to show "issues with the credentials" even though there are none. Loading the credentials as soon as we initiate the view seems to fix the issue. Specifically, we are trying to get the credentials errors for `predefinedCredentialType` and [here](https://github.com/n8n-io/n8n/blob/e995309789c886f9203290e6973149ad96102fb2/packages/editor-ui/src/composables/useNodeHelpers.ts#L397), we attempt to get the type by calling `getCredentialsByType`, but that method depends on `allCredentialsByType` which at the same time depends on the state property `allCredentials`. At the time of calling the credentials have not been loaded in the store, so it returns `[]` even though it should have returned the credentials type. This empty array causes the logic to show an incorrect error. The execution does follow: `Mounted` -> `ready (jsplumb)` -> `initView` - > `openWorkflow` -> `addNodes` -> `refreshNodeIssues` -> `getNodeIssue` ->` getNodeCredentialIssues` -> `credentialsStore.getCredentialsByType` (were we return [] because the store has not loaded yet.) -> at some point later we load the credentials for that workflow in the store (this should have happened before getNodeCredentialIssues) @cstuncsik Can you please have a look? I'm not too familiar with this side of the code, so I'm not sure whether this would break something else or if it's the best approach to solve the issue. So far, it seems to fix the problem. ## Related Linear tickets, Github issues, and Community forum posts https://linear.app/n8n/issue/ADO-2280/http-request-shows-credentials-not-set-warning-in-ui-despite ## Before changes https://www.loom.com/share/5c07e76288e84041b6b8abdf99a33b30?from_recorder=1&focus_title=1 ## After the changes https://www.loom.com/share/7ac13702dced4784bc1bb820a29ed5bc?from_recorder=1&focus_title=1 ## Review / Merge checklist - [x] PR title and summary are descriptive. ([conventions](../blob/master/.github/pull_request_title_conventions.md))  - [ ] Tests included.  - [ ] PR Labeled with `release/backport` (if the PR is an urgent fix that needs to be backported)

artildo · July 12, 2024, 11:39am

@Jon Yeah, thank you. Solved the issue.

system · July 19, 2024, 11:39am

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.