Problem with Woocommerce node, fails on Product > Get All

Alejandro_Bonnin · December 3, 2021, 8:53am

Hi everyone!

I’m trying to use Get All Products on the WooCommerce node and it returns “ERROR: Cannot read property ‘split’ of undefined”

The message it returns:

TypeError: Cannot read property 'split' of undefined
    at Object.woocommerceApiRequestAllItems (/usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/WooCommerce/GenericFunctions.js:47:44)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Object.execute (/usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/WooCommerce/WooCommerce.node.js:253:40)
    at async /usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/src/WorkflowExecute.js:447:47

The simple workflow I’m using:

{
“nodes”: [
{
“parameters”: {
“operation”: “getAll”,
“returnAll”: true,
“options”: {}
},
“name”: “WooCommerce”,
“type”: “n8n-nodes-base.wooCommerce”,
“typeVersion”: 1,
“position”: [
420,
300
]
}
],
“connections”: {}
}

n8n version: 0.151.0
Database: PostgreSQL
Running on docker using the latest image on DockerHub

Thanks in advance!

MutedJam · December 3, 2021, 10:44am

Hi @Alejandro_Bonnin, welcome to the community

I’m very sorry to hear you’re running into this problem. I’ll need to set up a WordPress instance and install WooCommerce to give this a go first hand and will report back once done. Just to make sure: You do have products added to your WooCommerce database, right?

On a more general note, when posting code like the JSON representation one of your workflow, would you be able to wrap it in a preformatted block by using this button (or by manually adding three backticks ``` above and below your snippet)?

This will help greatly with copying it as it will prevent the forum from applying any formatting (though in this case it’s not a real problem as this is not a very complex workflow ). I’ve also added these backticks to the question template to make it easier going forward.

Alejandro_Bonnin · December 3, 2021, 4:05pm

Thank you so much!!

Yes, right now I have 10,300 products in the database, but it only allows me to import up to 100 products and if I try to import all at once it gives me the error.

Understood, thanks for the advice. I’ll do it the next time!

Thanks in advance!

MutedJam · December 6, 2021, 12:03pm

Thanks @Alejandro_Bonnin, it’s quite helpful to see this is happening only for a larger amount of products. Based on this info I assume the problem would then only occur if the Return All option is enabled (as in your example workflow) but otherwise the node is working fine?

Maybe there’s a problem with the pagination logic then. I’ll insert some more products in my store next to see what happens.

MutedJam · December 6, 2021, 2:39pm

Okay, after adding a bit of additional logging I can see there definitely is definitely wrong with pagination when the Return All option is enabled.

The node would fetch page 1 and page 2 with 100 products each in an endless loop:

I could not reproduce the exact error you have described though @Alejandro_Bonnin. The split method from the error trace you have shared refers to the response headers received from WooCommerce, which for some reason does not seem to be available in your example. I wonder if this might just be a side effect of the problem I have noticed.

Let me fix the pagination problem first, maybe this also addresses your issue

MutedJam · December 6, 2021, 4:38pm

Found the issue and raised a pull request with a fix for the pagination problem:

github.com/n8n-io/n8n

🐛 WooCommerce: Fix pagination for getAll product operation

n8n-io:master ← that-one-tom:woocommerce-returnall-fix

opened 04:32PM - 06 Dec 21 UTC

that-one-tom

+6 -3

This PR addresses a problem [raised in our community](https://community.n8n.io/t…/problem-with-woocommerce-node-fails-on-product-get-all/9607) by member Alejandro_Bonnin. When enabling the *Return All* option on the *Get All* operation of the *Product* resource, WooCommerce can respond with a `link` header in which the `rel="prev"` URL appears before the `rel="next"` URL. Previously, n8n would always use the first URL from the `link` header. With this change, n8n searches for the correct `rel="next"` URL regardless of its position.

We’ll let you know once it’s released.

Alejandro_Bonnin · December 7, 2021, 10:30am

Hi! Thanks a lot @MutedJam
Have a nice day!

Regards, Alex

bitprecision · April 3, 2022, 3:18am

Hi Team,

Is there anyway to manually implement this fix or an ETA on when it might get included in the current release? Finding it hard to finish a few of my projects and trying to figure out if I am better off working around it if it might be some time until it’s fixed?

Cheers,
Chris

Jon · April 3, 2022, 7:37pm

Hey @bitprecision,

I am surprised that one has not been picked ip already, I will look at it tomorrow if no one gets to it and see if we can get it included in the next couple of weeks.

bitprecision · April 3, 2022, 10:46pm

Awesome! Thanks @Jon, love it!

Jon · April 4, 2022, 8:54am

Hey @bitprecision,

I have just done a review / test internally and it all looks good so I have passed it to the next step to get merged. We have been spending a lot of time working on reviewing the community node improvement PRs and missed this one.

In theory this one should be included next week / the week after so to be safe lets aim for before the end of the month just incase anything else pops up.

jan · April 6, 2022, 12:59pm

Fix got released with [email protected]

bitprecision · April 8, 2022, 5:06am

Perfect guys, works like a dream! Thank you

arfath77 · April 10, 2022, 8:47pm

Hello @MutedJam Can you please check if we have the same issue for getAll customer and orders operation?
I am getting error “there was some problem running the flow”.

Jon · April 11, 2022, 6:01am

Hey @arfath77,

Welcome to the community

There was an issue with customers and orders as well but during testing the change in 171.1 fixed it.

Before 171.1 you would get no error and it would keep trying to load the data, it sounds like you are getting a different issue.

Could you open a new thread and include the version of n8n you are running, the full error and a workflow that reproduces the issue.

arfath77 · April 11, 2022, 8:32pm

Thank you @Jon ! I was using version 0.169.0, have now updated to the latest version and things are working fine.

Jon · April 12, 2022, 9:48am

Hey @arfath77,

Fantastic that is good news

arfath77 · April 15, 2022, 8:01pm

Hello @Jon, is there any limit on getAll?, for me it fetching only 1000 records from quickbooks for customers

Jon · April 16, 2022, 6:45am

Hey @arfath77,

There shouldn’t be but sometimes the methods used for pagination changes so we need to tweak them as they come up.

Can you pop open a new thread for quickbooks and we can take a proper look after the holiday

Richard_Sessa_Alcara · July 4, 2023, 9:24am

Hello!
I have the same problem. When I try to retrieve all users.

TypeError: Cannot read properties of undefined (reading 'split')
    at Object.woocommerceApiRequestAllItems (/usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/WooCommerce/GenericFunctions.js:36:49)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.execute (/usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/WooCommerce/WooCommerce.node.js:128:40)
    at Workflow.runNode (/usr/local/lib/node_modules/n8n/node_modules/n8n-workflow/dist/Workflow.js:652:28)
    at /usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/WorkflowExecute.js:596:53

I use version 0.233.1 of n8n, WP 6.2.2 and WOO 7.8.2