Describe the problem/error/question
The S3 node has a couple of problems:
- BUG: The file download is not working in AI Agent context, it works on other linear flows.
Why: The propertybinaryPropertyNameis not set in agent context, why the control flow for writing the result is not executed. (see n8n/packages/nodes-base/nodes/S3/S3.node.ts at e5d88eba990edb343118494c4993098cfe478f17 · n8n-io/n8n · GitHub)
The GUI does not allow to add this property additionally.
I created a workaround for me, created a subworkflow, here it works.
-
FEATURE: A move option for files is missing
-
BUG or code smell: The Source looks pretty wild:
** a single function - 900 lines - I would suggest to create functions for at least all different resources
** a lot of repititions - if param then put in header, this could be done with a dict, and a single line instead of three, and make it 200 lines shorter
** extract functions that are done mutliple times and use constant for strings that are used multiple times.
I could fix it and create a pull request, but your guideline says to ask before change anything here.
Therefore → Should I fix and improve this points?
Please share your workflow
Information on your n8n setup
- **n8n version:**1.102.3
- Database (default: SQLite): SQLite
- n8n EXECUTIONS_PROCESS setting (default: own, main): own
- Running n8n via (Docker, npm, n8n cloud, desktop app): container (podman)
- Operating system: Ubuntu